Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ImportError's have a message #25636

Merged
merged 1 commit into from Apr 6, 2023
Merged

Ensure ImportError's have a message #25636

merged 1 commit into from Apr 6, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 6, 2023

PR Summary

Otherwise, you can get, e.g., a test skip with an empty message like:

lib/matplotlib/tests/test_getattr.py::test_getattr[matplotlib.backends.backend_gtk3] SKIPPED (Cannot import matplotlib.backends.backend_gtk3 due to)

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic
Ensure ImportError's have a message
b88a683 
Otherwise, you can get, e.g., a test skip with an empty message like:
```
lib/matplotlib/tests/test_getattr.py::test_getattr[matplotlib.backends.backend_gtk3] SKIPPED (Cannot import matplotlib.backends.backend_gtk3 due to)
```
@QuLogic QuLogic added this to the v3.7.2 milestone Apr 6, 2023
@oscargus oscargus merged commit 61ed3f4 into matplotlib:main Apr 6, 2023
38 of 40 checks passed
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 6, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 6, 2023
@oscargus @meeseeksmachine
Backport PR matplotlib#25636: Ensure ImportError's have a message
fdd5290
@QuLogic QuLogic deleted the import-message branch April 6, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
API: consistency
Projects
None yet
Milestone
v3.7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@QuLogic @timhoffm @oscargus