Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md to include issue cross-reference. #25737

Merged
merged 2 commits into from Apr 22, 2023

Conversation

chahak13
Copy link
Contributor

This changes the PR template to prompt/remind the user to link the issue it resolves. This is to make sure that it reduces duplicate PRs, as having a back link would make it easier to know that there's work being done on a particular issue.

PR Summary

PR Checklist

Documentation and Tests

  • [N/A] Has pytest style unit tests (and pytest passes)
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

This changes the PR template to prompt/remind the user to link the issue it resolves. This is to make sure that it reduces duplicate PRs, as having a back link would make it easier to know that there's work being done on a particular issue.
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering also if we can use githubs form schema and make this a required text area.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@chahak13
Copy link
Contributor Author

I'm wondering also if we can use githubs form schema and make this a required text area.

It doesn't have to be necessary because that might hamper just normal MNT PRs or something that's not related to the issue.

@QuLogic QuLogic added this to the v3.8.0 milestone Apr 22, 2023
@QuLogic QuLogic merged commit 7f05570 into matplotlib:main Apr 22, 2023
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants