MNT: update Shadow init signature #25872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
reviewed
May 12, 2023
rcomer
reviewed
May 12, 2023
rcomer
reviewed
May 12, 2023
|
I'm going to squash this down to one commit and we can not talk about the amount of tries it took ..... |
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
|
This has passed mypy and the stubs should not be used any where else so I'm going to merge before all of CI is done to un-break CI for all other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes typing bug from me merging #25389
The CI on that PR was from before we merge the typing so this was not checked.