Fix subslice optimization for long, fully nan lines. #25978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
added
Release critical
QuLogic
approved these changes
May 25, 2023
The subslice optimizer does not handle the case of fully nan inputs, so the relevant check in recache() is not whether x is sorted but really whether x is sorted and not fully nan. Fix that. Previously, `plt.plot([np.nan] * 2000, range(2000))` would crash.
|
Edit: also slightly tweaked the loop to fetch the stride info only once. |
oscargus
approved these changes
May 30, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 30, 2023
oscargus
added a commit
that referenced
this pull request
Jun 1, 2023
…978-on-v3.7.x Backport PR #25978 on branch v3.7.x (Fix subslice optimization for long, fully nan lines.)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subslice optimizer does not handle the case of fully nan inputs, so the relevant check in recache() is not whether x is sorted but really whether x is sorted and not fully nan. Fix that.
Previously,
plt.plot([np.nan] * 2000, range(2000))would crash.Regression due to #24581, sorry about that.
PR summary
PR checklist