Drop metadata table when subsetting fonts #25985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
May 26, 2023
This table contains a list of design/supported languages, which it doesn't make sense to keep in a subset. Fixes matplotlib#24025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 31, 2023
oscargus
added a commit
that referenced
this pull request
Jun 1, 2023
…985-on-v3.7.x Backport PR #25985 on branch v3.7.x (Drop metadata table when subsetting fonts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This table contains a list of design/supported languages, which it doesn't make sense to keep in a subset.
I don't really know that there's an easy way to test, as the current known trigger is Times New Roman, which we can't ship here.
Fixes #24025
PR checklist