Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnt: GUI tests #26060

Merged
merged 1 commit into from Jun 14, 2023
Merged

Mnt: GUI tests #26060

merged 1 commit into from Jun 14, 2023

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Jun 3, 2023

PR summary

Test some currently untested GUI methods. (get_window_title, smoke test for remove_rubberband.)

Replace unittest with pytest.

Add get_window_title method to webagg backend.

Remove tk-backend-marks (allowing tests to be run). Importability is checked in _isolated_tk_test.

PR checklist

@oscargus oscargus changed the title Test get_window_title Test GUI Jun 3, 2023
@oscargus oscargus force-pushed the guitest branch 5 times, most recently from d738656 to 0f45474 Compare June 4, 2023 12:03
@oscargus oscargus marked this pull request as ready for review June 4, 2023 13:03
@oscargus oscargus marked this pull request as draft June 4, 2023 13:11
@oscargus oscargus force-pushed the guitest branch 2 times, most recently from adea833 to 38061bd Compare June 4, 2023 13:34
@oscargus oscargus changed the title Test GUI Mnt: GUI tests Jun 4, 2023
@oscargus oscargus marked this pull request as ready for review June 4, 2023 14:49
@oscargus
Copy link
Contributor Author

oscargus commented Jun 8, 2023

@QuLogic Would you mind taking a look at this as you are working with the tests now?

@QuLogic QuLogic merged commit d50bca8 into matplotlib:main Jun 14, 2023
39 checks passed
@oscargus oscargus added this to the v3.8.0 milestone Jun 16, 2023
@oscargus oscargus deleted the guitest branch June 16, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants