Make annotate/OffsetFrom unaffected by later mutation of coordinates. #26466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unpacking (`x, y = xy`) is safe wrt. units (we already perform the same unpacking later when actually computing coordinates) and prevents later mutation of the input array from affecting the artist (or the OffsetFrom instance), which is consistent with other artists. While at it, also inline OffsetFrom._get_scale, which is a one-liner.
timhoffm
approved these changes
Aug 7, 2023
ksunden
approved these changes
Aug 7, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unpacking (
x, y = xy) is safe wrt. units (we already perform the same unpacking later when actually computing coordinates) and prevents later mutation of the input array from affecting the artist (or the OffsetFrom instance), which is consistent with other artists.While at it, also inline OffsetFrom._get_scale, which is a one-liner.
Closes #17566; supersedes #17567.
PR summary
PR checklist