Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: mathtext tutorial-consolidate explain and notes #26470

Merged
merged 1 commit into from Aug 31, 2023

Conversation

story645
Copy link
Member

@story645 story645 commented Aug 8, 2023

  • removed example section, expanded inline example, and added seealso out to example b/c I was confused on where to find the code and found clicking the image kinda unintuitive.
  • rearranged top paragraphs to frontload mathtext and demphasize the implementation details
  • changed the set of notes into a section and consolidated/clarified-see gitter convo - because felt like there were too many notes. I would prefer a table instead of a figure but couldn't get it working.
  • moved things around a bit in the fonts section
  • converted to sphinx-gallery mode

@story645 story645 force-pushed the mathtext_gallery branch 2 times, most recently from a1a1fd3 to 33e692d Compare August 8, 2023 22:43
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
@story645
Copy link
Member Author

story645 commented Aug 27, 2023

Moved things around so that I could start with a short what is mathtext that might be inaccurate - I'm not sure if mathtext is the parser/engine or the subset of TeX or both.

Also thanks for the review!

@timhoffm timhoffm marked this pull request as draft August 30, 2023 11:49
@timhoffm timhoffm marked this pull request as ready for review August 30, 2023 12:36
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice guide now. 👍

galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
galleries/users_explain/text/mathtext.py Outdated Show resolved Hide resolved
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@timhoffm timhoffm added this to the v3.8.0 milestone Aug 31, 2023
@timhoffm timhoffm merged commit 064781d into matplotlib:main Aug 31, 2023
19 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 31, 2023
oscargus added a commit that referenced this pull request Aug 31, 2023
…470-on-v3.8.x

Backport PR #26470 on branch v3.8.x ([DOC]: mathtext tutorial-consolidate explain and notes)
@story645 story645 deleted the mathtext_gallery branch August 31, 2023 18:32
@ksunden ksunden mentioned this pull request Sep 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants