Improve legend(loc='best') warning and test #26483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is never passed in explicitly, and this is otherwise private.
If a candidate location was picked, then that would be returned directly without warning even if it took just as long.
QuLogic
changed the title
QuLogic
force-pushed
the
loc-best-warning
branch
from
a36b09f
to
e6c001d
Compare
By patching the timer instead of using actually large data, we can both a) speed up these tests (~7.5s vs <0.2s for both), and b) consistently trigger the warning even on systems which are fast (such as the M1 systems on Cirrus.) Also, copy the test data from `test_legend_auto3`, which correctly hits all candidate locations for the 'best' legend locator without having to fill up the entire Axes with data.
QuLogic
force-pushed
the
loc-best-warning
branch
from
e6c001d
to
3cc6610
Compare
tacaswell
approved these changes
Aug 10, 2023
ksunden
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The
considerargument fromLegend._find_best_positioncan be removed, as no-one ever uses it and this is a private method.Because of an early
return, the warning thatloc='best'is slow can sometimes not be triggered, so ensure that is the case.Finally, improve the test for this warning. By patching the timer instead of using actually large data, we can both:
Also, copy the test data from
test_legend_auto3, which correctly hits all candidate locations for the 'best' legend locator without having to fill up the entire Axes with data.PR checklist