-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closes #26477 ENH: Add interpolation_stage in qt figureoptions #26500
closes #26477 ENH: Add interpolation_stage in qt figureoptions #26500
Conversation
d8d880c
to
4f3b7ac
Compare
Hello @Tsufael - just noting that if you want this to be reviewed, make sure you mark it as "Ready for review". Thanks! |
I do not think that the figure options dialog is currently tested. You will need to add something like
to For the PR it looks OK, but will have to try it out manually before I can fully tell/approve. |
4f3b7ac
to
c54675d
Compare
This appears to work as far as I can tell. I rebased and added the type hint as this seems almost complete. |
add interpolation_stage selector for images in qt figureoptions
c54675d
to
518d70f
Compare
One more rebase to fix linting and docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the figure options locally, and it works. Anyone can merge if/when CI passes.
Thanks for your first PR to Matplotlib!
I'm not sure if demonstration in an [example] and writing tests for this PR applies.
Closes #26477
PR summary
Add getter for image interpolation_stage;
Add interpolation_stage selector for images in qt figureoptions.
The getter was added to check what option should be selected when the menu is opened.
PR checklist