Add ninja to Cygwin builder #26543
Merged
Add ninja to Cygwin builder #26543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there are no contourpy wheels, it must be built from source, and pre-packaged ninja is better than trying to build from sdist.
|
I think this failed because we need a |
|
Maybe the best workaround until the next contourpy release is to explicitly build it without build isolation, something like (unchecked): python -m pip install meson-python pybind11
python -m pip install --no-build-isolation contourpy |
|
It looks like that has worked after a couple tries. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 21, 2023
ksunden
added a commit
that referenced
this pull request
Aug 21, 2023
…543-on-v3.8.x Backport PR #26543 on branch v3.8.x (Add ninja to Cygwin builder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Since there are no contourpy wheels, it must be built from source, and pre-packaged ninja is better than trying to build from sdist. This was always done, but broke when contourpy switched to Meson.
PR checklist