Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standard formatters in axisartist. #26586

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 23, 2023

Ideally, axisartist-specific formatters (and locators) should be deprecated and removed in the future.

Closes #18295 (see the modified test & baseline image for an example).

PR summary

PR checklist

oscargus
oscargus previously approved these changes Aug 24, 2023
@oscargus oscargus dismissed their stale review August 24, 2023 11:13

Didn't notice that the tests failed...

Ideally, axisartist-specific formatters (and locators) should be
deprecated and removed in the future.
@anntzer
Copy link
Contributor Author

anntzer commented Aug 24, 2023

Indeed, fixed (some arch-dependent baseline image apparently...). Unfortunately there seems to remain a tiny bit of arch-dependent stuff which makes it impossible to have strictly the same baseline image on GHA CI and on Azure CI (setting tol to zero and having a passing test on GHA results in an image mismatch on Azure) so I left a tiny tol (less that previously) on the test.

@oscargus oscargus added this to the v3.9.0 milestone Aug 31, 2023
@QuLogic QuLogic merged commit ad18e34 into matplotlib:main Sep 27, 2023
39 checks passed
@anntzer anntzer deleted the aaf branch September 27, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to modify ticklabels in axisartist?
4 participants