Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional props argument to Lasso Widget __init__ to customize Lasso line #26594

Merged
merged 13 commits into from
Mar 13, 2024

Conversation

kbturk
Copy link
Contributor

@kbturk kbturk commented Aug 24, 2023

PR summary

Added an optional props argument to the Lasso Widget init to allow customization of the Lasso line and a test to check the new code. This is similar to the LassoSelector optional props argument and props must be properties in Line2D.

PR checklist

*There is a tutorial for the Lasso Widget but since this is an optional argument it doesn't need to be updated.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

lib/matplotlib/widgets.py Outdated Show resolved Hide resolved
lib/matplotlib/widgets.py Outdated Show resolved Hide resolved
@oscargus
Copy link
Contributor

Thanks for your contribution! Some comments to get the doc builds to pass and have a slightly more expected interface. The idea is good for sure!

@oscargus oscargus added this to the v3.9.0 milestone Aug 30, 2023
lib/matplotlib/widgets.py Outdated Show resolved Hide resolved
lib/matplotlib/widgets.py Outdated Show resolved Hide resolved
Copy link
Contributor

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For whoever merges this: please squash upon merge.

@QuLogic
Copy link
Member

QuLogic commented Mar 13, 2024

It looks like there are some conflicts here; are you able to rebase this PR?

@timhoffm
Copy link
Member

I've fix the conflict (expired kw-only deprecation vs. Modified signature).

Please squash-merge.

lib/matplotlib/widgets.py Outdated Show resolved Hide resolved
@timhoffm timhoffm merged commit 6368cc5 into matplotlib:main Mar 13, 2024
41 of 42 checks passed
@timhoffm
Copy link
Member

Thank you for your work @kbturk and congratulations on your first merged Matplotlib PR 🎉

I hope we hear from you again.

@kbturk
Copy link
Contributor Author

kbturk commented Mar 14, 2024

Thank you @timhoffm @QuLogic @oscargus for all the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants