-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional props argument to Lasso Widget __init__ to customize Lasso line #26594
Conversation
updated Lasso documentation with props updated Lasso documentation with props
Lasso test passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Thanks for your contribution! Some comments to get the doc builds to pass and have a slightly more expected interface. The idea is good for sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
For whoever merges this: please squash upon merge.
It looks like there are some conflicts here; are you able to rebase this PR? |
I've fix the conflict (expired kw-only deprecation vs. Modified signature). Please squash-merge. |
Thank you for your work @kbturk and congratulations on your first merged Matplotlib PR 🎉 I hope we hear from you again. |
PR summary
Added an optional props argument to the Lasso Widget init to allow customization of the Lasso line and a test to check the new code. This is similar to the LassoSelector optional props argument and props must be properties in Line2D.
PR checklist
*There is a tutorial for the Lasso Widget but since this is an optional argument it doesn't need to be updated.