Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add ACCEPTS for some Axes set methods #26641

Merged
merged 1 commit into from Aug 30, 2023

Conversation

oscargus
Copy link
Contributor

PR summary

If I understand things correctly, this will provide information to the property tables and avoid "unknown".

PR checklist

@timhoffm
Copy link
Member

Do you have a link to a property table that is affected?

@oscargus
Copy link
Contributor Author

(I've earlier found these ACCEPTS quite confusing as I didn't understand what they were used for, but then I saw that something happened with xlim and ylim and realized that was exactly what they were doing...)

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now.

FYI: The obscure .. ACCEPTS doc comments should be repaced by a decorator in the future, see 2#2699.

@timhoffm timhoffm added this to the v3.8.0 milestone Aug 30, 2023
@timhoffm timhoffm merged commit 8d56b9c into matplotlib:main Aug 30, 2023
41 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 30, 2023
@oscargus
Copy link
Contributor Author

Yes, I agree that they are obscure. But since they solve the problem and there seems to be issues agreeing on the decorator...

@oscargus oscargus deleted the figuremethodtypes branch August 30, 2023 18:55
QuLogic added a commit that referenced this pull request Aug 30, 2023
…641-on-v3.8.x

Backport PR #26641 on branch v3.8.x ([Doc] Add ACCEPTS for some Axes set methods)
@ksunden ksunden mentioned this pull request Sep 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants