Added sanitize_sequence to kwargs in _preprocess_data #26670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
story645
added
API: consistency
API: argument checking
New feature
topic: plotting methods
and removed
API: argument checking
labels
story645
force-pushed
the
fix-for-issue-25596
branch
from
b55adc1
to
824e684
Compare
Added a simple test for using errorbar with mapview kwarg Changed errorbar kwarg test to be more explicit
story645
force-pushed
the
fix-for-issue-25596
branch
from
824e684
to
643ec42
Compare
ksunden
approved these changes
Sep 1, 2023
rcomer
approved these changes
Sep 3, 2023
|
Milestoned for 3.9 as it has the “New Feature” label, though I think it could reasonably be considered a bugfix? |
|
It's both? Kwargs was never supported so that's new, but this also fixes the barh problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally broke #25702 trying to rebase it 🤦♀️ so this is my amends (and for future I will make a new branch/PR for these sorts of rebases). @jovianw's PR makes it so that **kwargs are also passed through
_sanitize_sequenceand adds a test.This pr supercedes #26577, which is why I touched it.
Let me know if it's considered enough of a new feature to need a what's new.