PR template: shorten comment and pull up top#26686
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom Sep 3, 2023
Merged
Conversation
rcomer
approved these changes
Sep 3, 2023
timhoffm
approved these changes
Sep 3, 2023
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
The more compact the better. I’m all for reducing this to the very essentials. Every additional sentence will make more people just ignore the whole block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion in #26684 makes the point that folks aren't really reading the big block of text comment, so here I'm breaking it up into the sections each part of the comment is related to and deleting the information that's also in the checkbox. The stuff about the title can also be moved into the checkbox. I also maybe wouldn't object to reducing this further and moving some of this content into the contributor guide.