Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: separate and clarify axisartist default tables #26754

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

story645
Copy link
Member

@story645 story645 commented Sep 12, 2023

PR summary

Based on discussion in #26737, rotated the parameter default table in the AxisArtist guide and seperated it out into two to try and clarify that the table is showing the default label parameter values for each reference direction.

general new look:
image

attn: @oscargus

PR checklist

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on splitting the table. -1 on changing to list table style. As said in #26737 (comment)

As long as the tables are small (like in this example), I prefer ReST simple tables. Yes they are more cumbersome to update but they are much easier to read, and readability counts. It's not that we are changing these tables all the time.

@story645
Copy link
Member Author

I may be the anomaly but I don't find the list tables harder to read if the table is sensible since it's still row/column order. And I usually have the rendered docs open. On the flip side, I find the hardcoded tables orders of magnitude more annoying to edit - I dunno if it's a byproduct of being on Windows or eyestrain but I always manage to miss something, especially when I have to cascade the changes.

@timhoffm
Copy link
Member

I accept your different standpoint. Let’s if others have an opinion.

@oscargus
Copy link
Contributor

I'm with Tim here. Two tables clearly made it better (from both source and rendering perspectives), but still I find the "hard-to-edit" tables much easier to understand.

@story645
Copy link
Member Author

story645 commented Oct 6, 2023

changed to grid tables c/o nice vs code plugins + table usage doc/section formatting

@story645 story645 mentioned this pull request Oct 5, 2023
16 tasks
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go modulo the typos.

+-------------+-------------------------------+--------------------+
| | small table | large table |
+-------------+-------------------------------+--------------------+
| short entry | `simple or grid table <sg>`__ | `grid table <sg>`_ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's one underscore too much:

Suggested change
| short entry | `simple or grid table <sg>`__ | `grid table <sg>`_ |
| short entry | `simple or grid table <sg>`_ | `grid table <sg>`_ |

Comment on lines 5 to 7
=== ========== =======
The axisartist toolkit
=== ========== =======
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is unintended. Have you been playing with table formatting too much? 😜

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a format all instead of format this

@story645
Copy link
Member Author

story645 commented Oct 6, 2023

fixed

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any body can merge after applying above heading formatting suggestion.

galleries/users_explain/toolkits/axisartist.rst Outdated Show resolved Hide resolved
@QuLogic QuLogic merged commit cfe5bf7 into matplotlib:main Oct 7, 2023
19 checks passed
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 7, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.8.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 cfe5bf75eaf378b9523830908036f2123acfe4e7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #26754: DOC: seperate and clarify axisartist default tables'
  1. Push to a named branch:
git push YOURFORK v3.8.x:auto-backport-of-pr-26754-on-v3.8.x
  1. Create a PR against branch v3.8.x, I would have named this PR:

"Backport PR #26754 on branch v3.8.x (DOC: seperate and clarify axisartist default tables)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 7, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.8.0-doc
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 cfe5bf75eaf378b9523830908036f2123acfe4e7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #26754: DOC: seperate and clarify axisartist default tables'
  1. Push to a named branch:
git push YOURFORK v3.8.0-doc:auto-backport-of-pr-26754-on-v3.8.0-doc
  1. Create a PR against branch v3.8.0-doc, I would have named this PR:

"Backport PR #26754 on branch v3.8.0-doc (DOC: seperate and clarify axisartist default tables)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@QuLogic QuLogic modified the milestones: v3.8-doc, v3.9.0 Oct 26, 2023
@QuLogic QuLogic changed the title DOC: seperate and clarify axisartist default tables DOC: separate and clarify axisartist default tables Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: user guide files in galleries/users_explain or doc/users topic: mpl_toolkit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants