Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Numpy 2.0 removals from ndarray class #26762

Merged
merged 1 commit into from Sep 14, 2023

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Sep 13, 2023

PR summary

xref numpy/numpy#24682

Only a handful of lines, and mostly in tests/relatively unused utility functions like rgb_to_hsv, but still something that should be addressed.

PR checklist

xref numpy/numpy#24682

Only a handful of lines, and _mostly_ in tests/relatively unused utility functions like rgb_to_hsv, but still something that should be addressed.
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it matters too much, but the upstream PR does do the view before byteswap.

@ksunden
Copy link
Member Author

ksunden commented Sep 14, 2023

I'm pretty sure those are equivalent; byteswap will incur a copy (unless inplace=True) and view is just a view, but whether the copy comes before or after the view doesn't really matter.

@timhoffm timhoffm added this to the v3.8.0 milestone Sep 14, 2023
@timhoffm timhoffm merged commit 4c73219 into matplotlib:main Sep 14, 2023
41 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 14, 2023
@ksunden ksunden mentioned this pull request Sep 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants