Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc build (alternative) #26818

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Sep 18, 2023

Attempt to fix doc build failure introduced with #25272.

I suspect this is sphinx scoping: #25272 reused methods like Axes.set_xbounds to generate documentation for Axes3D. However, a see also of invert_xaxis only searches within the same module (or class), and invert_xaxis is not documented for Axes3D. This PR attempt to explicitly document the missing methods for Axes3D.

Only one of #26817, #26818 should be used, preferrably #26818 if it works out.

Attempt to fix doc build failure introduced with matplotlib#25272.

I suspect this is sphinx scoping: matplotlib#25272 reused methods
like `Axes.set_xbounds` to generate documentation for Axes3D. However,
a see also of invert_xaxis only searches within the same module (or
class), and invert_xaxis is not documented for Axes3D. This PR
attempt to explicitly document the missing methods for Axes3D.
@timhoffm timhoffm mentioned this pull request Sep 18, 2023
Copy link
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had made this change locally and was running a doc build when this PR came in.

My doc build passed, so I expect the Circle one to as well

@tacaswell tacaswell added this to the v3.9.0 milestone Sep 18, 2023
@tacaswell tacaswell merged commit f6bdfd3 into matplotlib:main Sep 18, 2023
18 checks passed
@timhoffm timhoffm deleted the fix-doc-build2 branch September 19, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants