Reduce redundant information in _process_plot_var_args.#26840
Merged
ksunden merged 2 commits intomatplotlib:mainfrom Sep 20, 2023
Merged
Reduce redundant information in _process_plot_var_args.#26840ksunden merged 2 commits intomatplotlib:mainfrom
ksunden merged 2 commits intomatplotlib:mainfrom
Conversation
_prop_keys is redundant with _cycler_items and not really needed anywhere. Removing it makes it less likely that a _process_plot_var_args gets in an invalid state if _cycler_items is updated while _prop_keys is not touched.
- Swap arguments on _getdefaults so that ignores can be made optional. - Inline some temporaries, and use more comprehensions.
Member
|
failures look unrelated (build system looks like it is fighting back): |
tacaswell
approved these changes
Sep 20, 2023
Member
|
Yes, that resulted from the (now yanked) setuptools-scm v8.0.0, so restarting tests now that that shouldn't be a problem. |
Member
|
Remaining CI failures appear to be #26846 (plus the doc build which seems to have not rebooted on that power cycle, but this is only touching private functionality anyway, so not too concerned about that) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_prop_keys is redundant with _cycler_items and not really needed anywhere. Removing it makes it less likely that a _process_plot_var_args gets in an invalid state if _cycler_items is updated while _prop_keys is not touched.
Inspired by #26831.
A second separate commit adds some minor cleanups.
PR summary
PR checklist