Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Julian date support #26852

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

oscargus
Copy link
Contributor

PR summary

PR checklist

@tacaswell
Copy link
Member

#26849 should fix azure, merging over the failure.

I am curious about why John added this to begin with (they came in in 2006!).

@tacaswell tacaswell merged commit 1bea95f into matplotlib:main Sep 21, 2023
36 of 40 checks passed
@WeatherGod
Copy link
Member

John had a background in Perl, and Julian calendar support is pretty complete in it. Also, Julian day is a bit special because it uses the international date line (180 degrees longitude) instead of the prime meridian as its delimiter for days. This helps with grouping international data by common days, which I'd imagine is useful for people in finance, which John was also involved in for his job.

@oscargus oscargus deleted the julianremoval branch September 21, 2023 18:19
@jklymak
Copy link
Member

jklymak commented Sep 21, 2023

We maybe could consider ammending the change note to indicate the conversion from our num to Julian days. It's a straightforward offset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants