Cleaned up the span_where class method from Polycollections. #26874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Sep 22, 2023
QuLogic
reviewed
Sep 22, 2023
tacaswell
reviewed
Sep 22, 2023
lib/matplotlib/collections.py
Outdated
| "the compressed values is deprecated. " | ||
| "Pass the full 2D shape of the original array " | ||
| f"{prev_unmask.shape} including the masked elements.") | ||
| "the compressed values is deprecated. " |
There was a problem hiding this comment.
Were these changes intentional?
There was a problem hiding this comment.
The pep8 linter fixed the sapcings.
|
Linting shows that there is a little more fallout from this removal:
|
|
Sorry, there is one more remaining instance in the docs at |
|
yayy! finally the build passed. 👯 |
QuLogic
reviewed
Sep 25, 2023
| @@ -221,7 +221,6 @@ Added size related functions to specialized `.Collection`\s | |||
| Added the ``get_size`` and ``set_size`` functions to control the size of | |||
| elements of specialized collections ( | |||
| :class:`~matplotlib.collections.AsteriskPolygonCollection` | |||
| :class:`~matplotlib.collections.BrokenBarHCollection` | |||
There was a problem hiding this comment.
This shouldn't be removed from old docs, even though it doesn't exist any more, because it's a historical reflection of "what's new in 1.4". Mark it as code style instead:
Suggested change
| :class:`~matplotlib.collections.BrokenBarHCollection` | |
| ``matplotlib.collections.BrokenBarHCollection`` |
14 tasks
QuLogic
approved these changes
Sep 25, 2023
rcomer
approved these changes
Sep 27, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR removes the deprecated code during the version 3.7 from lib/matplotlib/collection.py which is a sub issue in the parent issues here: #26865
PR checklist