Fix masking for Axes3D.plot() #26906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksunden
reviewed
Sep 25, 2023
scottshambaugh
force-pushed
the
3d_masking
branch
3 times, most recently
from
e49c8b4
to
95dd95d
Compare
ksunden
approved these changes
Oct 16, 2023
timhoffm
reviewed
Oct 16, 2023
Move function to cbook Whitespace Privatize cbook._broadcast_with_masks
scottshambaugh
force-pushed
the
3d_masking
branch
from
85977b0
to
a5cb9ef
Compare
QuLogic
reviewed
Oct 18, 2023
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com> Co-authored-by: Kyle Sunden <git@ksunden.space>
QuLogic
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #25043 - there was someone who volunteered to look at doing that fix, but I'm not seeing any action on the ticket for the past 9 months and this will block some work I want to do on dynamic masking
Consolidates some the masking logic that was happening in different plotting functions into a private cbook function.
PR checklist