Deprecate ContourLabeler.add_label_clabeltext. #26917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Sep 30, 2023
Comment on lines
3
to
5
| ... is deprecated. `.ContourLabeler.add_label` now sets | ||
| `.Text.set_transform_rotates_text` based on the value of *use_clabeltext* | ||
| passed to the `.ContourLabeler` constructor. |
There was a problem hiding this comment.
The latter part of this note belongs in a behaviour change note, I think.
We can just dispatch add_label based on the value of the internal _use_clabeltext flag. This change is also preparing for a possible future change where we always have use_clabeltext=True (which is needed for contour labels to be properly rotated after changes of axes aspect ratio, and should have no drawback except for a tiny(?) performance cost).
ksunden
approved these changes
Oct 2, 2023
QuLogic
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can just dispatch add_label based on the value of the internal _use_clabeltext flag. This change is also preparing for a possible future change where we always have use_clabeltext=True (which is needed for contour labels to be properly rotated after changes of axes aspect ratio, and should have no drawback except for a tiny(?) performance cost).
PR summary
PR checklist