Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tomli to rstcheck extras #26935

Merged
merged 1 commit into from
Sep 27, 2023
Merged

add tomli to rstcheck extras #26935

merged 1 commit into from
Sep 27, 2023

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Sep 27, 2023

required for reading config from pyproject.toml on py<3.11

PR summary

PR checklist

@ksunden
add tomli to rstcheck extras
e8f21d2 
required for reading config from pyproject.toml on py<3.11
jklymak
jklymak approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably there is no need to CI this?

story645
story645 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is totally needs one review but you can self merge at your discretion

@ksunden ksunden added the CI: testing CI configuration and testing label Sep 27, 2023
@QuLogic QuLogic added this to the v3.9.0 milestone Sep 27, 2023
@QuLogic QuLogic merged commit 55d7005 into matplotlib:main Sep 27, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
CI: testing CI configuration and testing
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ksunden @story645 @jklymak @QuLogic