Deprecate backend_ps.get_bbox_header, and split it for internal use. #26960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Sep 30, 2023
| def get_bbox_header(lbrt, rotated=False): | ||
| """ | ||
| Return a postscript header string for the given bbox lbrt=(l, b, r, t). | ||
| Optionally, return rotate command. | ||
| """ | ||
| return _get_bbox_header(lbrt), (_get_rotate_command(lbrt) if rotated else None) |
There was a problem hiding this comment.
Old behaviour was an empty string
Suggested change
| return _get_bbox_header(lbrt), (_get_rotate_command(lbrt) if rotated else None) | |
| return _get_bbox_header(lbrt), (_get_rotate_command(lbrt) if rotated else "") |
It's clearly an internal helper, and the two parts (the actual bbox header and the rotation command) don't really benefit from being smushed together, so make the function private and split the two parts.
ksunden
approved these changes
Oct 2, 2023
QuLogic
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's clearly an internal helper, and the two parts (the actual bbox header and the rotation command) don't really benefit from being smushed together, so make the function private and split the two parts.
PR summary
PR checklist