Minor cleanups. #26967
Merged
Minor cleanups. #26967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
approved these changes
Oct 2, 2023
story645
requested changes
Oct 2, 2023
Re: the rewriting of AsinhLocator formulas: The previous implementation added 1e-6 to the logs in the case where xs=0 in order to avoid a warning with log(0), but the result of the log was then zeroed out by multiplication by xs anyways. Instead, here we just rely on `10**log(0) = 10**-inf = 0`.
story645
approved these changes
Oct 2, 2023
ksunden
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: the rewriting of AsinhLocator formulas: The previous implementation added 1e-6 to the logs in the case where xs=0 in order to avoid a warning with log(0), but the result of the log was then zeroed out by multiplication by xs anyways. Instead, here we just rely on
10**log(0) = 10**-inf = 0.PR summary
PR checklist