Fixes Issue #26377 - Auto-escape % Symbol in Latex in pie labels #26981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksunden
requested changes
Oct 3, 2023
timhoffm
approved these changes
Feb 18, 2024
dstansby
reviewed
Feb 20, 2024
|
I am a tad confused by the title. It says "operator", but it is only letting I think this needs a whats new entry so that we can highlight this if anyone has been (ab)using this to intentionally put comments into strings. |
Vashesh08
changed the title
timhoffm
reviewed
Feb 24, 2024
tacaswell
changed the title
Fixes Issue matplotlib#26377 - Adding Support For % operator in Latex Excaping The % Operator in LaTeX for the Pie method Update _axes.py Added usetex key in textprops dictionary in pie method Removing Flake Issues and Prioritizing textprops parameter Fixes % operator in Latex in Pie Method Removed Trailing Whitespace Removed Unnecessary Label Test in Pie Update lib/matplotlib/tests/test_axes.py Skip Test when latex is not available Co-authored-by: Kyle Sunden <git@ksunden.space> Update lib/matplotlib/tests/test_axes.py Update test_name for % operator in Latex in Pie Method Co-authored-by: Kyle Sunden <git@ksunden.space> Added Dependency for needs_usetex testing for checking Latex dependency Comment For Using Regex To Support % Symbol in Latex Comments added to escape % if not already escaped using regex Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
ksunden
approved these changes
Apr 3, 2024
tacaswell
approved these changes
Apr 3, 2024
|
Going to skip waiting for AppVeyor, as the fix for it isn't in yet, and this shouldn't affect it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes Issue #26377 - Adding Support For % operator in Latex. Continued From #26642
'%' operator is considered as the start of a comment in LaTeX. In order to avoid this behavior,
\%needs to be used.Uses Regex to substitute
\%instead of%. It also resolves in case the string is already pre-escaped.PR checklist