Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section to Highlight past winners for JDH plotting contest in docs #27021

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

Tahaabdul
Copy link
Contributor

@Tahaabdul Tahaabdul commented Oct 6, 2023

PR summary

  • Changed placement of the python graph gallery from tutorials section to galleries

PR checklist

Added a link to past winners for the JDH plotting contest in fixing issue matplotlib#11129
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

=========


[Past winners for JDH plotting contest](https://jhepc.github.io/gallery.html)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bullet point this one as well? Also, this file uses RST syntax, not Markdown. You can learn about RST here: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html

Copy link
Contributor Author

@Tahaabdul Tahaabdul Oct 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out, changed it.

@story645 story645 added the Documentation: user guide files in galleries/users_explain or doc/users label Oct 6, 2023
changed formatting on JDH plotting link to RST syntax.
@pamelafox
Copy link

@Tahaabdul You can see the staged docs here: https://output.circle-artifacts.com/output/job/f699e534-516d-4ca4-bb70-50ba920cfe39/artifacts/0/doc/build/html/users/resources/index.html
It looks like the author name for the first gallery is rendering on a separate line, can you get it to render on same line like others?

@rcomer
Copy link
Member

rcomer commented Oct 8, 2023

Could you also change the title of this pull request to something more descriptive?

@Tahaabdul Tahaabdul changed the title Update index.rst Add a section to Highlight past winners for JDH plotting contest in docs Oct 8, 2023
realigned contest link, and author items under galleries section to render on same line
Copy link

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment looks good! I'll let a matplotlib maintainer take it from here.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tahaabdul (and @pamelafox for the review help!)

@jklymak jklymak merged commit 0d17fb0 into matplotlib:main Oct 8, 2023
19 checks passed
@jklymak
Copy link
Member

jklymak commented Oct 8, 2023

BTW, I squashed the commits here as I assume you don't care about the history.

@QuLogic QuLogic added this to the v3.9.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: user guide files in galleries/users_explain or doc/users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight past winners for JDH plotting contest in docs
6 participants