Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test_hist in test_datetime.py #27028

Merged
merged 9 commits into from
Oct 12, 2023
Merged

Conversation

yangyangdotcom
Copy link
Contributor

PR summary

Added test_hist method in test_datetime.py as part of the #26859
Figure_1

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good. However, can you also check that specifying the bin edges in datetime64 works?

@yangyangdotcom
Copy link
Contributor Author

Do you want me to do it in a new method or have datetime64 and datetime in the same method?

@jklymak
Copy link
Member

jklymak commented Oct 8, 2023

Sorry I didn't note that you had tested datetime not datetime64. I think testing datetime as the bin edges should be fine.

@yangyangdotcom
Copy link
Contributor Author

Is there any other things that I need to do for this PR to be merged?

@jklymak
Copy link
Member

jklymak commented Oct 8, 2023

My original request still stands. Please also test with a list of datetimes as the bin edges in addition to testing bins=10.

@yangyangdotcom
Copy link
Contributor Author

Test with a list of datetimes as the bin edges:
Figure_2

@yangyangdotcom
Copy link
Contributor Author

Let me know if I am doing it right or if there are any other requirements. Thank you

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Needs another reviewer, but looks great to me

@ksunden ksunden merged commit 7c02e85 into matplotlib:main Oct 12, 2023
40 checks passed
@ksunden
Copy link
Member

ksunden commented Oct 12, 2023

Thank you, congrats on your merged PR, hope to hear from you again!

@ksunden ksunden added this to the v3.9.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants