Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test_axhspan in test_datetime.py #27139

Merged
merged 3 commits into from
Oct 20, 2023
Merged

added test_axhspan in test_datetime.py #27139

merged 3 commits into from
Oct 20, 2023

Conversation

danielcobej
Copy link
Contributor

@danielcobej danielcobej commented Oct 18, 2023

I´ve added code for test_axhspan method in test_datetime.py mentioned in issue #26864

Image output: (edited)
download

PR summary

PR checklist

Copy link
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither of the axes have units on the y axis, which is the one that matters for axhspan. As such, no datetime values are being passed to the function we are trying to test.

@danielcobej
Copy link
Contributor Author

Neither of the axes have units on the y axis, which is the one that matters for axhspan. As such, no datetime values are being passed to the function we are trying to test.

Sorry, it should be fixed now.

@ksunden
Copy link
Member

ksunden commented Oct 18, 2023

Can you provide a new image that is produced?

@danielcobej
Copy link
Contributor Author

Can you provide a new image that is produced?

Yes, just changed the old one in PR summary.

@ksunden ksunden added this to the v3.9.0 milestone Oct 20, 2023
@ksunden ksunden merged commit fcd5bb1 into matplotlib:main Oct 20, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants