Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: clean up links under table formatting docs #27199

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

story645
Copy link
Member

@story645 story645 commented Oct 25, 2023

I guess I forgot to add a line and nobody checked the final build - currently all the urls in the table are batched underneath 😬

image

this PR also fixes the links πŸ€¦β€β™€οΈ

I guess I forgot a space and nobody checked the final build - currently all the urls in the table are batched underneath and they should be hidden
@story645 story645 added the Documentation: devdocs files in doc/devel label Oct 25, 2023
@story645 story645 added this to the v3.8-doc milestone Oct 25, 2023
@story645 story645 marked this pull request as draft October 25, 2023 22:24
@story645 story645 marked this pull request as ready for review October 25, 2023 22:33
@QuLogic QuLogic modified the milestones: v3.8-doc, v3.9.0 Oct 26, 2023
@QuLogic QuLogic merged commit bbb0a61 into matplotlib:main Oct 26, 2023
19 checks passed
@story645 story645 deleted the format-table-urls branch October 26, 2023 13:52
@story645
Copy link
Member Author

Um @QuLogic I milestones this for docs cause currently none of those links work

@QuLogic
Copy link
Member

QuLogic commented Oct 26, 2023

I couldn't find this table on the stable docs. It appears that #26754 still needs a manual backport.

@story645
Copy link
Member Author

Oops but also not worth backporting. Thanks!

@QuLogic
Copy link
Member

QuLogic commented Oct 26, 2023

Not worth backporting this one, or the original?

@story645
Copy link
Member Author

Both? This in particular is a dev doc thing so as long as it's fixed in the dev docs/any versions this docs show up I'm fine.

@QuLogic
Copy link
Member

QuLogic commented Oct 26, 2023

I'll remove the label from #26754 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: devdocs files in doc/devel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants