Merged
Conversation
QuLogic
reviewed
Nov 8, 2023
Mostly just unwrapping long lists of arguments into a single line where possible.
QuLogic
approved these changes
Nov 8, 2023
ksunden
reviewed
Nov 8, 2023
lib/matplotlib/dviread.py
Outdated
Comment on lines
+145
to
+147
| # slen1: Read (delta + 1) bytes as an unsigned number. | ||
| ulen1=lambda dvi, delta: dvi._arg(delta + 1, signed=False), | ||
| # slen1: Read (delta + 1) bytes as an unsigned number if less than 4 bytes, |
Member
There was a problem hiding this comment.
Suggested change
| # slen1: Read (delta + 1) bytes as an unsigned number. | |
| ulen1=lambda dvi, delta: dvi._arg(delta + 1, signed=False), | |
| # slen1: Read (delta + 1) bytes as an unsigned number if less than 4 bytes, | |
| # ulen1: Read (delta + 1) bytes as an unsigned number. | |
| ulen1=lambda dvi, delta: dvi._arg(delta + 1, signed=False), | |
| # olen1: Read (delta + 1) bytes as an unsigned number if less than 4 bytes, |
ksunden
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent cleanup commits:
PR summary
PR checklist