FIX: also exclude np.nan in RGB(A) in color mapping #27303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
previously approved these changes
Nov 10, 2023
anntzer
reviewed
Nov 10, 2023
| if norm and (xx.max() > 1 or xx.min() < 0): | ||
| if norm and ( | ||
| np.any(np.isnan(xx)) or (xx.max() > 1 or xx.min() < 0) | ||
| ): |
There was a problem hiding this comment.
Rewrite as
if not (xx.min() >= 0 and xx.max() <= 1) (with a comment explaining that this form also excludes nans) and no extra nan checking to save a tiny bit of performance?
|
I checked out this branch and found it does not affect the examples in #27301. I think because Unless I've done something silly, which is always possible... |
oscargus
dismissed
their stale review
As there were doubts about how to handle it (and now if it actually works), it is probably better that I do not approve (only) based on seemingly sensible code.
2 tasks
|
Closing in favor of #27301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27301
PR summary
The docstring says "values must be on [0, 1] gamut" as is our standard encoding for float RGB(A) arrays. We check that the min and max are not outside of this range, but due to the way comparisons work with
np.nanour test erroneously passed.This adds an explict check for
np.nanPR checklist