Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: add _version.py to .gitignore #27374

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

StefRe
Copy link
Contributor

@StefRe StefRe commented Nov 27, 2023

PR summary

_version.py is generated by setuptools_scm when you do an editable install and should not be tracked in version control.

PR checklist

_version.py is generated by setuptools_scm and should not be
tracked in version control
Copy link
Contributor

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should definitely be ignored. Strange that it wasn't earlier...

(Although I most often use git commit -a ... so that may be why I haven't noticed it.)

@rcomer rcomer added this to the v3.9.0 milestone Nov 27, 2023
@rcomer rcomer merged commit 4394666 into matplotlib:main Nov 27, 2023
38 of 39 checks passed
@StefRe StefRe deleted the mnt/gitignore branch November 27, 2023 17:30
@QuLogic
Copy link
Member

QuLogic commented Nov 28, 2023

If you have a _version.py, it's a leftover from some other branch or older commit. The Meson build puts _version.py in the build directory, not the source. This was removed on purpose, as you should be deleting it if you have the leftover file.

@StefRe
Copy link
Contributor Author

StefRe commented Nov 28, 2023

Yes, my bad: the _version.py in lib\matplotlib\ was created by a v3.8 install, v3.9 creates the file in build\cp311\lib\matplotlib\ which is ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants