Fix setting _selection_completed
in SpanSelector
when spanselector is initialised using extents
#27409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
In the following example, if the first click is outside of the span selector, the span selector will be reset on the press event, while it shouldn't. The reason is that when setting
extents
programmatically after initialisation of the span selector, the attribute_selection_completed
should beTrue
, otherwise the span selector will behave as the selection was incomplete!PR checklist