Switch pytest fixture from tmpdir to tmp_path #27417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
approved these changes
Dec 1, 2023
tmp_path is the more modern version providing standard pathlib.Path objects and preferred nowadays https://docs.pytest.org/en/7 .4.x/reference/reference.html#tmpdir.
|
Done. I should definitively set up precommit. |
story645
approved these changes
Dec 1, 2023
|
Yeah, pre-commit is pretty nice once it works! Anyone can merge on green. |
|
do we want this backported for later PRs writing against this code or let the backporting happen as part of backporting those prs? |
|
I would not backport. The likelihood of backporting changes to tests is quite small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmp_path is the more modern version providing standard pathlib.Path objects and preferred nowadays https://docs.pytest.org/en/7 .4.x/reference/reference.html#tmpdir.