Fix some minor issues with hexbin bins argument #27441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Dec 5, 2023
oscargus
approved these changes
Dec 5, 2023
|
Not sure if this should be backported or not? Seems to be rather non-controversial as it is a bug-fix (although maybe not a regression), and the example fix can definitely go there. I'll set it to backport and then someone can complain and not merge the backport... |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 5, 2023
QuLogic
added a commit
that referenced
this pull request
Dec 5, 2023
…441-on-v3.8.x Backport PR #27441 on branch v3.8.x (Fix some minor issues with hexbin bins argument)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Since
binsaccepts a sequence, it may take a NumPy array, so the string comparison needs to handle that.Also fix the colorbar label from #27383.
PR checklist