Remove unnecessary del local variables at end of Gcf.destroy. #27498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`del manager, num` made sense prior to 9f3861f when we used to then call gc.collect(1) (so we needed to delete the variables from the local frame so that they can be gc'ed if needed), but we have since then removed the explicit gc call; thus the del statement doesn't really do anything anymore (the local frame is about to be destroyed and thus all local variables will be decref'ed anyways).
QuLogic
approved these changes
Dec 12, 2023
timhoffm
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
del manager, nummade sense prior to 9f3861f when we used to then call gc.collect(1) (so we needed to delete the variables from the local frame so that they can be gc'ed if needed), but we have since then removed the explicit gc call; thus the del statement doesn't really do anything anymore (the local frame is about to be destroyed and thus all local variables will be decref'ed anyways).PR summary
PR checklist