Fix docs and add tests for transform and deprecate BboxTransformToMaxOnly
#27513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Dec 14, 2023
oscargus
force-pushed
the
transformtestdoc
branch
from
35178b3
to
d252665
Compare
|
Let's just deprecate and kill bboxtransformtomaxonly (in another pr if you prefer), it's not been used since 10y ago. |
|
I can add the deprecation here. (Easier to know the PR number etc...) |
oscargus
changed the title
BboxTransformToMaxOnly
anntzer
approved these changes
Dec 14, 2023
QuLogic
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
One may consider deprecating
BboxTransformToMaxOnlyas it is not used in the code base. But at least the doc-string should be correct.PR checklist