Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin black version #27606

Merged
merged 2 commits into from Jan 8, 2024
Merged

Pin black version #27606

merged 2 commits into from Jan 8, 2024

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jan 6, 2024

PR summary

Each calendar year black can make updates/changes to how they format code (see the black stability policy). To make sure our autogenerated pyplot.py corresponds to a particular version of black, add a pin to the version. When we want to update we can then bump the major version of black and regenerate pyplot.py in sync.

Fixes partially #27529 - I'm not sure if there's a way to run the weekly GH actions workflows on a PR to check this works?

PR checklist

environment.yml Outdated Show resolved Hide resolved
requirements/testing/all.txt Outdated Show resolved Hide resolved
@dstansby dstansby marked this pull request as ready for review January 6, 2024 17:18
@tacaswell tacaswell added this to the v3.8.3 milestone Jan 8, 2024
@tacaswell tacaswell merged commit bda1afa into matplotlib:main Jan 8, 2024
41 of 42 checks passed
@tacaswell
Copy link
Member

The test failure is a wx memory test that is also failing on main

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 8, 2024
@dstansby dstansby deleted the pin-black branch January 8, 2024 15:09
QuLogic added a commit that referenced this pull request Jan 9, 2024
…606-on-v3.8.x

Backport PR #27606 on branch v3.8.x (Pin black version)
@rcomer rcomer mentioned this pull request Mar 10, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants