Add option of running stubtest using tox #27618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried modifying |
|
It looks like I added an error that stubest doesn't check for. I've go tox/stubtest working now, just need to fix |
dstansby
force-pushed
the
stubtest-tox
branch
from
8403fa3
to
fc592cd
Compare
|
Fab, this seems to be working now |
ksunden
requested changes
Jan 11, 2024
.github/workflows/mypy-stubtest.yml
Outdated
| pip3 install -r requirements/testing/mypy.txt \ | ||
| -r requirements/testing/all.txt | ||
| pip3 install . | ||
| python-version: 3.11 |
There was a problem hiding this comment.
I think we do want to run on the oldest supported python version to avoid accidentally allowing typing features that were introduced more recently.
lib/matplotlib/axis.py
Outdated
| @@ -40,6 +40,10 @@ | |||
| } | |||
|
|
|||
|
|
|||
| def new_func(x): | |||
There was a problem hiding this comment.
This test func should be removed, it did error on CI.
There was a problem hiding this comment.
馃憤 I removed the commit with this in
Fix reviewdog sed Add tox install stage
dstansby
force-pushed
the
stubtest-tox
branch
from
de4623e
to
106ce16
Compare
ksunden
reviewed
Jan 15, 2024
Co-authored-by: Kyle Sunden <git@ksunden.space>
ksunden
approved these changes
Jan 16, 2024
QuLogic
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives developers the option of running stubtests using
tox. This is useful, because the stubtests can't be run on local editable installs (see #27580).I've added a test commit that breaks stubtest deliberately to show this works - I will leave this here for review purposes, then force push it away once this has one approved review.
I can't get this to give me a true negative result locally though 馃槩 . With the below diff (saved, but unstaged in git), runningtox -e stubteststill gives me a successful result. I'll investigate a bit further, but I don't suppose anyone has any ideas?Fixes #27580.
PR summary
PR checklist