Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axes.inset_axes - warning message removed #27665

Merged
merged 15 commits into from
Jan 23, 2024
Merged

Conversation

ShivamPathak99
Copy link
Contributor

@ShivamPathak99 ShivamPathak99 commented Jan 18, 2024

Changed Axes.inset_axes status to stable #27648

Changed the status of Axes.inset_axes from experimental to stable in docs.
Created new file in next_whats_new for inset_axes.
Fixed the wrong fork

Closes #27648

PR checklist

Removed warning message of inset_axes
This method is experimental as of 3.0, and the API may change.
Changed status from experimental to stable
@github-actions github-actions bot added the Documentation: user guide files in galleries/users_explain or doc/users label Jan 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just doc formatting, but also one unrelated change is included

doc/users/next_whats_new/inset_axes.rst Outdated Show resolved Hide resolved
doc/users/next_whats_new/inset_axes.rst Outdated Show resolved Hide resolved
@ShivamPathak99
Copy link
Contributor Author

Why 2 of the checks failed ?

@ksunden
Copy link
Member

ksunden commented Jan 20, 2024

One is an unrelated memory problem we have been having (nothing for you to do on that)

The other is wanting the new line at the end of the release note to be taken out, I believe.

@ShivamPathak99
Copy link
Contributor Author

codecov/project/tests is failing, but why ?

@tacaswell tacaswell added this to the v3.9.0 milestone Jan 22, 2024
@tacaswell tacaswell changed the title Axes.inset_axes - warning message remvoved [DOCS] Axes.inset_axes - warning message remvoved Jan 22, 2024
@tacaswell tacaswell added API: changes and removed Documentation: user guide files in galleries/users_explain or doc/users labels Jan 22, 2024
@tacaswell
Copy link
Member

I'm unclear why the bot added "documention user guide" as this is moving part of the API from experimental to stable so it is closest to an API change.


Coverage data is based on HEAD 95b7f68
(10 uploads)
compared to BASE 879bde7
(14 uploads)

more CI jobs contributed to the run on the base commit.

From looking at the indirect changes it looks like we are missing an upload from an osx runner and something with a pre-release of pytest8.

@ksunden
Copy link
Member

ksunden commented Jan 22, 2024

I'm unclear why the bot added "documention user guide"

The release note matches this file glob:

"Documentation: user guide":
- changed-files:
- any-glob-to-any-file:
- 'doc/users/**'

Perhaps that glob can be narrowed (especially for next_whats_new)

@dstansby dstansby dismissed ksunden’s stale review January 23, 2024 10:45

Changes addressed

@dstansby dstansby merged commit 2122f65 into matplotlib:main Jan 23, 2024
43 of 45 checks passed
@QuLogic QuLogic changed the title Axes.inset_axes - warning message remvoved Axes.inset_axes - warning message removed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Axes.inset_axes is still experimental
6 participants