Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Don't include API/what's new notes in general doc labels #27689

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 23, 2024

PR summary

PRs that touch doc/users/next_whats_new/* because they have a new feature shouldn't be labelled as "user guide" updates, and similar for API notes.

PR checklist

@QuLogic QuLogic added this to the v3.9.0 milestone Jan 23, 2024
@timhoffm
Copy link
Member

We don't have an explicit guideline for infrastructure at https://matplotlib.org/devdocs/devel/pr_guide.html#merging. But I think such changes can be merged with just one approval.

@dstansby dstansby merged commit a7ee09e into matplotlib:main Jan 23, 2024
40 of 41 checks passed
@QuLogic QuLogic deleted the less-doc-labelling branch January 23, 2024 09:43
@timhoffm
Copy link
Member

Ping @QuLogic

This appears to not work. It caused a failure in #27690:

image

@QuLogic
Copy link
Member Author

QuLogic commented Jan 23, 2024

Oops, I deleted a -to- somehow. I wonder if I can find a schema somewhere so I can lint these before hand.

@ksunden ksunden mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants