Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOV: adopt EffVer #27702

Merged
merged 3 commits into from
Feb 8, 2024
Merged

GOV: adopt EffVer #27702

merged 3 commits into from
Feb 8, 2024

Conversation

tacaswell
Copy link
Member

EffVer very closely articulates what we are already doing.

This was discussed on the developer call last week and was positively received.

I used git grep to find all '* version' and * release referring to our releases (I left "minor version" in most places in the minimum dependency document when referring to other projects, but expanded the definition at the top).


I would like approval from 2 other steering council members before we merge.

@tacaswell tacaswell added this to the v3.9.0 milestone Jan 25, 2024
@story645 story645 added governance needs approval from @steering-council and removed topic: text/fonts Documentation: build building the docs labels Jan 25, 2024
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some small changes still needed.

doc/devel/release_guide.rst Outdated Show resolved Hide resolved
doc/devel/release_guide.rst Outdated Show resolved Hide resolved
doc/devel/release_guide.rst Outdated Show resolved Hide resolved
doc/devel/release_guide.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added Documentation: user guide files in galleries/users_explain or doc/users Documentation: API files in lib/ and doc/api labels Jan 25, 2024
src/ft2font_wrapper.cpp Outdated Show resolved Hide resolved
@WeatherGod
Copy link
Member

WeatherGod commented Jan 26, 2024 via email

@timhoffm
Copy link
Member

IMHO the point is that we haven't really made any commitment to what our version numbers mean. It's definitively not SemVer because we make breaking changes in minor releases. Even though that happens with a defensive compatibility policy (deprecation periods and not too disruptive changes), these would require a major release in SemVer.

You can only encode one kind of information in the version number, not both new features and degree of compatibility. And chosing between these two compatibility is the more helpful one. I think in practice, we'll continue to have both new features and minor API changes in the minor/meso releases.

While we could define our own meaning for the version numbers, it's better to use a common semantic. Since SemVer is out and EffVer essentially matches our compatibility policy, it's a good choice.

Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, and several places where it looks like
"major" should be "macro" for consistency. Otherwise, fine with me.

doc/devel/release_guide.rst Outdated Show resolved Hide resolved
doc/devel/release_guide.rst Outdated Show resolved Hide resolved
doc/devel/release_guide.rst Outdated Show resolved Hide resolved
tacaswell and others added 2 commits February 6, 2024 21:51
EffVer very closely articulates what we are already doing.

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@tacaswell
Copy link
Member Author

We have 2 positive SC reviews so I'm going to go ahead and merge this.

@tacaswell tacaswell merged commit 634ee03 into matplotlib:main Feb 8, 2024
43 checks passed
@tacaswell tacaswell deleted the pol/adopt_effver branch February 8, 2024 21:16
tacaswell added a commit to tacaswell/website that referenced this pull request Feb 8, 2024
jacobtomlinson pushed a commit to jacobtomlinson/website that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: API files in lib/ and doc/api Documentation: build building the docs Documentation: devdocs files in doc/devel Documentation: user guide files in galleries/users_explain or doc/users Documentation governance needs approval from @steering-council topic: text/fonts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants