TST: always set a (long) timeout for subprocess and always use our wrapper#27726
Merged
greglucas merged 3 commits intomatplotlib:mainfrom Feb 14, 2024
Merged
TST: always set a (long) timeout for subprocess and always use our wrapper#27726greglucas merged 3 commits intomatplotlib:mainfrom
greglucas merged 3 commits intomatplotlib:mainfrom
Conversation
If you are using this and really need unbounded timeouts, explicitly pass `timeout=None`
tacaswell
changed the title
Member
Author
|
The second commit finally cleans up all of the |
tacaswell
force-pushed
the
tst/finite_tests
branch
2 times, most recently
from
1bfdf4d to
ec90d87
Compare
QuLogic
reviewed
Feb 1, 2024
tacaswell
force-pushed
the
tst/finite_tests
branch
from
3727a38 to
2852ff7
Compare
QuLogic
reviewed
Feb 9, 2024
Member
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
Unfortunately, while subprocess_run_helper defaults to check=True, subprocess_run_for_testing defaults to check=False.
tacaswell
force-pushed
the
tst/finite_tests
branch
from
2852ff7 to
0515861
Compare
QuLogic
approved these changes
Feb 9, 2024
greglucas
approved these changes
Feb 14, 2024
|
|
||
| def subprocess_run_for_testing(command, env=None, timeout=None, stdout=None, | ||
| def subprocess_run_for_testing(command, env=None, timeout=60, stdout=None, | ||
| stderr=None, check=False, text=True, |
Contributor
There was a problem hiding this comment.
Suggested change
| stderr=None, check=False, text=True, | |
| stderr=None, check=True, text=True, |
Since this is used for testing it seems like we should set check=True by default. It looks like you currently set this in many of the calls. Are there even more tests without setting check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you are using this and really need unbounded timeouts, explicitly pass
timeout=NoneThis is an attempt to avoid azure from hanging and then timing out.