-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move doc/users/installing/ to doc/install/ #27747
Conversation
0539200
to
c7f314d
Compare
Probably gonna need a git grep here, but the following will likely need to be updated:
|
Hey, I'm not sure why two of the tests are failing. I would appreciate some help |
@rcomer caught that you probably need to rebase b/c there's been changes to the tests/CI code. The needs-rebase flag didn't get triggered b/c that code doesn't conflict with this PR. |
bee8735
to
61a8555
Compare
@story645 done! |
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@@ -61,7 +61,7 @@ dev = [ | |||
|
|||
[project.urls] | |||
"Homepage" = "https://matplotlib.org" | |||
"Download" = "https://matplotlib.org/stable/users/installing/index.html" | |||
"Download" = "https://matplotlib.org/stable/install/index.html" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it ok to change this now or should this wait for the other redirects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine; it'll only affect the rc page, and once final is out, we'll update the main page to go along with it.
Oops, I thought of squashing earlier, but didn't; oh well. |
PR summary
This PR addresses the issue #27396 on moving non user guide related content out of /users. This is the second step, moving
/doc/users/installing
->/doc/install
.PR checklist
/users
#27396"