Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move doc/users/installing/ to doc/install/ #27747

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

shriyakalakata
Copy link
Contributor

PR summary

This PR addresses the issue #27396 on moving non user guide related content out of /users. This is the second step, moving /doc/users/installing -> /doc/install.

PR checklist

@story645
Copy link
Member

Probably gonna need a git grep here, but the following will likely need to be updated:
*

@github-actions github-actions bot added Documentation: devdocs files in doc/devel Documentation: user guide files in galleries/users_explain or doc/users Documentation: API files in lib/ and doc/api labels Mar 13, 2024
@shriyakalakata shriyakalakata marked this pull request as ready for review March 14, 2024 04:50
@shriyakalakata
Copy link
Contributor Author

Hey, I'm not sure why two of the tests are failing. I would appreciate some help

@story645
Copy link
Member

story645 commented Apr 1, 2024

@rcomer caught that you probably need to rebase b/c there's been changes to the tests/CI code. The needs-rebase flag didn't get triggered b/c that code doesn't conflict with this PR.

@shriyakalakata
Copy link
Contributor Author

shriyakalakata commented Apr 2, 2024

you probably need to rebase b/c there's been changes to the tests/CI code

@story645 done!

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic QuLogic added this to the v3.9.0 milestone Apr 4, 2024
@@ -61,7 +61,7 @@ dev = [

[project.urls]
"Homepage" = "https://matplotlib.org"
"Download" = "https://matplotlib.org/stable/users/installing/index.html"
"Download" = "https://matplotlib.org/stable/install/index.html"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to change this now or should this wait for the other redirects?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine; it'll only affect the rc page, and once final is out, we'll update the main page to go along with it.

@QuLogic QuLogic merged commit feb2780 into matplotlib:main Apr 4, 2024
43 checks passed
@QuLogic
Copy link
Member

QuLogic commented Apr 4, 2024

Oops, I thought of squashing earlier, but didn't; oh well.

@shriyakalakata shriyakalakata deleted the install_docs branch April 4, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: API files in lib/ and doc/api Documentation: devdocs files in doc/devel Documentation: user guide files in galleries/users_explain or doc/users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Move non user guide related content out of /users
3 participants