Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some Meson internals #27752

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Update some Meson internals #27752

merged 3 commits into from
Feb 8, 2024

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 7, 2024

PR summary

As we depend on Meson 1.1, I went through the release notes to see if there was anything new we could take advantage of (as I only bumped the requirement to get the pybind11 dependency and nothing else).

This gets us 3 things:

  • Rename meson_options.txt to meson.options, added in 1.1. Mostly a cosmetic change, but perhaps allows better file type detection from editors.
  • Use dependency('dl') instead of cc.find_library('dl'); the builtin check might be more portable than just looking for a linkable library.
  • Add license_files to Meson metadata; it doesn't do anything, but maybe if meson-python implements PEP639, this data will be used.

PR checklist

This new name was added in Meson 1.1, which is our minimum requirement.
This was added in 0.62, and maybe is a bit more portable.
@QuLogic QuLogic added the Build label Feb 7, 2024
@QuLogic QuLogic added this to the v3.9.0 milestone Feb 7, 2024
This doesn't get used for anything effectively, but perhaps meson-python
will start using it eventually.
@tacaswell tacaswell merged commit 49aad96 into matplotlib:main Feb 8, 2024
41 of 43 checks passed
@QuLogic QuLogic deleted the meson-update branch February 8, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants