MNT: pcolormesh robust underflow #27773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
reviewed
Feb 12, 2024
lib/matplotlib/tests/test_axes.py
Outdated
| def test_pcolormesh_underflow_error(): | ||
| """ | ||
| Test that underflow errors don't crop up in pcolormesh. Probably | ||
| a numpy bug, but... |
There was a problem hiding this comment.
Suggested change
| a numpy bug, but... | |
| a numpy bug. See https://github.com/matplotlib/matplotlib/issues/27770. |
There was a problem hiding this comment.
If we think this is a numpy bug, we should also report it upstream.
|
numpy/numpy#25810 <- upstream issue. |
jklymak
force-pushed
the
mnt-pcolormesh-robust-underflow
branch
from
fdfeba2
to
793f1df
Compare
jklymak
changed the title
dstansby
approved these changes
Feb 12, 2024
tacaswell
approved these changes
Feb 12, 2024
|
anyone can merge if appveyor is green. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27770
This looks to be a numpy masked array problem, but multiplication doesn't trigger the spurious underflow, and probably is a touch faster as well.