FIX: be careful about communicating with subprocess #27785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows on py312 we can not use `.communicate` during process shutdown because it internally uses Python threads which can no longer be created during interpreter shutdown. Closes matplotlib#27437
ksunden
approved these changes
Feb 13, 2024
greglucas
approved these changes
Feb 14, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 14, 2024
QuLogic
added a commit
that referenced
this pull request
Feb 14, 2024
…785-on-v3.8.x Backport PR #27785 on branch v3.8.x (FIX: be careful about communicating with subprocess)
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Feb 14, 2024
…utdown FIX: be careful about communicating with subprocess (cherry picked from commit c90234f)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows on py312 we can not use
.communicateduring process shutdown because it internally uses Python threads which can no longer be created during interpreter shutdown.Closes #27437